This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Add opentelemetry instrumentation #146
Open
hamersaw
wants to merge
11
commits into
master
Choose a base branch
from
feature/open-telemetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 68.18% 66.75% -1.44%
==========================================
Files 69 73 +4
Lines 4083 4268 +185
==========================================
+ Hits 2784 2849 +65
- Misses 1141 1249 +108
- Partials 158 170 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Dan Rammer <[email protected]>
closed in favor of #149 |
8 tasks
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
This was referenced Mar 9, 2023
Signed-off-by: Daniel Rammer <[email protected]>
hamersaw
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
March 11, 2023 01:56
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Does it also change are |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adding a new
telemetryutils
package that adapts the opentelemetry functionality for use in Flyte repos. This includes support for multipleTracerProviders
allowing logical partitioning of tracers within single binary. Also instruments the blobstore and provides a wrapper for instrumenting k8s client.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3304
Follow-up issue
NA