This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
[Storage] Allow setting http headers for default http client #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
EngHabu
changed the title
kumare3
reviewed
Apr 13, 2020
storage/config.go
Outdated
| Limits LimitsConfig `json:"limits" pflag:",Sets limits for stores."` | ||
| Cache CachingConfig `json:"cache"` | ||
| Limits LimitsConfig `json:"limits" pflag:",Sets limits for stores."` | ||
| DefaultHTTPClient *HTTPClientConfig `json:"defaultHttpClient" pflag:",Sets the default http client config."` |
There was a problem hiding this comment.
this makes it sound like a client, not a config for a client.
There was a problem hiding this comment.
Similar to Cache? the entire thing is a config but then I'm terrible with names... suggestions?
|
up to you on the name, let me know when you want a +1 |
wild-endeavor
previously approved these changes
Apr 14, 2020
wild-endeavor
previously approved these changes
Apr 14, 2020
wild-endeavor
approved these changes
Apr 15, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Exposes a config in storage config section to allow setting http headers to the default http client. This is because some of the underlying storage systems (e.g. s3 stow) doesn't allow setting some settings (e.g. ACL) and the only way to support that is through setting HTTP HEADERS that AWS S3 respects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Exposes a config in storage config section to allow setting http headers to the default http client. This is because some of the underlying storage systems (e.g. s3 stow) doesn't allow setting some settings (e.g. ACL) and the only way to support that is through setting HTTP HEADERS that AWS S3 respects.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#261