Add support for PreSigned URLs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Mar 21, 2022
wild-endeavor
approved these changes
Mar 21, 2022
wild-endeavor
approved these changes
Mar 21, 2022
azure/container.go
Outdated
| @@ -32,6 +34,11 @@ func (c *container) Name() string { | |||
| return c.id | |||
| } | |||
|
|
|||
| func (c *container) PreSignRequest(_ context.Context, _ stow.ClientMethod, _ string, | |||
| _ stow.PresignRequestParams) (url string, err error) { | |||
| return "", fmt.Errorf("unsupported") | |||
There was a problem hiding this comment.
if azure won't work, does this mean we're going to have to have logic in flytectl to detect if we're trying to use azure storage, and then switch back to using the current logic?
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PreSigned URL generation in S3, GCS and Minio. It's stubbed out in other implementations for now..
Ref: flyteorg/flyte#2263