remove crate defined timezone constants #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to enable build-time timezone filtering (chrono-tz feature filter-by-regex).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the crate defined copy of chrono-tz timezone constants. This mainly to enable build-time timezone filtering (by the
chrono-tzfeaturefilter-by-regex). And this (again) mainly to decrease binary size (in similarity to #113).I guess one draw back might be that you will need chrono_tz as a dependency to modify an rrule timezone. On the other hand the rrule lib could possibly re-export chrono_tz timezones to make it more convenient to work with.
I understand that this might not be wanted but since I will have this in my fork anyway I might as well create a PR and ask.