Remove lazy_static dependency in favor of std OnceLock
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reported Clippy lint failures should be fixed by #131. |
AlexTMjugador
force-pushed
the
refactor/lazy-static-removal
branch
from
c4f6b2f to
812d794
Compare
fmeringdal
requested changes
Jan 27, 2025
AlexTMjugador
force-pushed
the
refactor/lazy-static-removal
branch
from
812d794 to
3132c20
Compare
WhyNotHugo
reviewed
Jan 28, 2025
WhyNotHugo
reviewed
Jan 28, 2025
Co-authored-by: Hugo <[email protected]>
Co-authored-by: Hugo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSRV of this crate is higher than 1.70, which introduced
std::sync::OnceLock, a type which can act as a similarly ergonomic replacement for thelazy_staticandonce_cellcrates. Pulling the least dependencies is always welcome by users of a library such asrrule, so let's replace uses oflazy_lockwithOnceLock.