[#948] Add onPost/Pause and onPost/Unpause hooks #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #948 We have onPost/Activate and onPost/Deactivate hooks, but equivalent (and useful) hooks for un/pausing traps don't exist. The new hooks are called before/after critical moments in the un/pausing process. Like the de/activation hooks, they can also be one-time overridden via a new `options` parameter in the trap's `pause(options)` and `unpause(options)` methods.
🦋 Changeset detectedLatest commit: 55f8eb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
We have onPost/Activate and onPost/Deactivate hooks, but equivalent (and useful) hooks for un/pausing traps don't exist.
The new hooks are called before/after critical moments in the un/pausing process.
Like the de/activation hooks, they can also be one-time overridden via a new
optionsparameter in the trap'spause(options)andunpause(options)methods.PR Checklist
Please leave this checklist in your PR.
yarn demo-bundlein your branch and include the/docs/demo-bundle.jsfile that gets generated in your PR).// TEST MANUALLYcomments here) that can't be fully tested in Cypress have been manually verified.typeof document/window !== 'undefined'before using it in code that gets executed on load.yarn changesetlocally to add one, and follow the prompts).