Implement EFI host creation #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2023
ekohl
force-pushed
the
implement-efi
branch
2 times, most recently
from
9167c0d
to
56b0b8f
Compare
|
I really don't like the RuboCop style rules that are set up ... |
This implements EFI host creation by specifying the os_firmware attribute to be efi. It's also possible to set the os_loader attribute to secure (for UEFI secure boot) or stateless (for AMD SEV). Both secure and stateless imply the os_firmware to be efi.
Closed
|
What is needed to move forward with this? I would like to start using efi for pxebooting libvirt VMs via foreman. |
ekohl
commented
Jul 22, 2024
| type = xml.type(os_type, :arch => arch) | ||
| type[:machine] = "q35" if ["i686", "x86_64"].include?(arch) | ||
|
|
||
| # TODO: can you use both secure and stateless at the same time? | ||
| case attributes[:os_loader] |
There was a problem hiding this comment.
Note to self: https://libvirt.org/kbase/secureboot.html says the os_loader was only needed for libvirt >= 7.2 < 8.6
|
Made redundant by #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements EFI host creation by specifying the os_firmware attribute to be efi. It's also possible to set the os_loader attribute to secure (for UEFI secure boot) or stateless (for AMD SEV). Both secure and stateless imply the os_firmware to be efi.
It includes #132 because the secure boot loader creates NVRAM and otherwise you wouldn't be able to delete those machines.
Only minimal testing on Fedora 38 has been done, but I can create VMs and have them boot up.
Fixes #128