This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
fix aiohttp dependency #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinscale
approved these changes
Jan 15, 2018
|
Temporary fix for now. |
pintomax
approved these changes
Jan 15, 2018
MarkRiddoch
reviewed
Jan 16, 2018
There was a problem hiding this comment.
If we move to aiohttp 2.3.8 do we still need this or should we have a different version?
I don't like that we are adding dependencies that are not things we depend on directly but are things that the packages we use depend on. The consequence is bad if those package get broken, but equally if we do this then we have to track carefully the dependency tree for everything we depend on.
|
for 2.3.6 released version yarl 0.18.0 (already released as well) is good; that way we can ensure it always using that tested compatible version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until aio-libs/aiohttp#2662 is fixed.
We need this in 1.1 and master too