Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.google.fonts/test/065: Is there kerning info for non-ligated sequences? change to WARN #1623

Closed
m4rc1e opened this issue Oct 25, 2017 · 1 comment
Closed

com.google.fonts/test/065: Is there kerning info for non-ligated sequences? change to WARN #1623

m4rc1e opened this issue Oct 25, 2017 · 1 comment
Assignees
@felipesanches
Labels
P1 Quick
Milestone
0.3.3 (upcoming m...

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 25, 2017

According to the test rationale:

Fonts with ligatures should have kerning on the corresponding
non-ligated sequences for text where ligatures aren't used
(eg impallari/Raleway#14).

This shouldn't be a FAIL, it should be WARN imo. In many instances, non ligated sequences don't need kerning, in some cases they do (The Raleway example is definitely one where it is needed).

This test is similar to the recommended contour count and out of bounds coordinates. Both are just WARN.
@felipesanches felipesanches self-assigned this Oct 25, 2017
@felipesanches felipesanches added this to the 0.3.3 milestone Oct 25, 2017
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 25, 2017
@felipesanches
Make test/065 emit a WARN instead of FAILing
e9ec6e8 
(issue fonttools#1623)
@felipesanches felipesanches mentioned this issue Oct 25, 2017
Merged
felipesanches added a commit that referenced this issue Oct 25, 2017
@felipesanches
Make test/065 emit a WARN instead of FAILing
1052757 
(issue #1623)
@davelab6
Copy link
Contributor

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P1 Quick
Projects
None yet
Milestone
0.3.3 (upcoming minor release)
Development

No branches or pull requests
3 participants
@felipesanches @davelab6 @m4rc1e