Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit only a WARNing for bad fonts on test/163 #1626

Merged
merged 1 commit into from
Oct 26, 2017
Merged

emit only a WARNing for bad fonts on test/163 #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/fontbakery/specifications/googlefonts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4680,7 +4680,7 @@ def com_google_fonts_test_163(ttFont):
platformID=plat):
if len(familyname_str + stylename_str) > 20:
failed = True
yield FAIL, ("The combined length of family and style"
yield WARN, ("The combined length of family and style"
" exceeds 20 chars in the following '{}' entries:"
" FONT_FAMILY_NAME = '{}' / SUBFAMILY_NAME = '{}'"
"").format(PLATID_STR[plat],
Expand Down
6 changes: 3 additions & 3 deletions Lib/fontbakery/specifications/googlefonts_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2187,7 +2187,7 @@ def test_id_163():
status, message = list(test(ttFont))[-1]
assert status == PASS

# Then we FAIL with the long family/style names
# Then we emit a WARNing with the long family/style names
# that were used as an example on the glyphs tutorial
# (at https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances):
for index, name in enumerate(ttFont["name"].names):
Expand All @@ -2200,9 +2200,9 @@ def test_id_163():
ttFont["name"].names[index].string = "WithAVeryLongStyleName".encode(name.getEncoding())
break

print ("Test FAIL with a bad font...")
print ("Test WARN with a bad font...")
status, message = list(test(ttFont))[-1]
assert status == FAIL
assert status == WARN


def test_id_164():
Expand Down