chore: swapping Husky to prepare rather than postinstall #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@claylevering Thank you for making a PR for this! The original change does not work as intended because yarn v4 does not support Please try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1531 - the Husky package should no longer be executed as a
postinstallscript and should instead be part of thepreparephase of the NPM lifecycle scripts (thus keeping Husky out of package installations).Caveat - I am not a Yarn user so I ::hope:: that this breaks nothing. It appeared to function for me, though I encourage @foray1010 to validate before publishing anything.