Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Implemented getting flags by identity and setting traits at the same time #1

Merged
merged 2 commits into from
May 31, 2024
Merged

Implemented getting flags by identity and setting traits at the same time #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0836222
Implemented getting flags by identity and setting traits at the same …
jackforesightmobile May 31, 2024
af668ac
Fix formatting
jackforesightmobile May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions FlagsmithClient/Classes/Flagsmith.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,21 @@
completion(result.map(\.traits))
}
}

/// Get flags for an identity and set traits in the same call
///
/// - Parameters:
/// - traits: Traits to be created or updated
/// - identity: ID of the user
/// - completion: Closure with Result which contains a list of Flags in case of success or Error in case of failure
public func getIdentityFlags(_ traits: [Trait],
forIdentity identity: String,

Check warning on line 279 in FlagsmithClient/Classes/Flagsmith.swift

View workflow job for this annotation

GitHub Actions / swift-lint 

Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
completion: @Sendable @escaping (Result<[Flag], any Error>) -> Void)

Check warning on line 280 in FlagsmithClient/Classes/Flagsmith.swift

View workflow job for this annotation

GitHub Actions / swift-lint 

Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
jackforesightmobile marked this conversation as resolved.
Show resolved Hide resolved
{
apiManager.request(.postTraits(identity: identity, traits: traits)) { (result: Result<Traits, Error>) in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to do something with the error?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just mirrored the other methods that do things with traits

completion(result.map(\.flags))
}
}

/// Get both feature flags and user traits for the provided identity
///
Expand Down
7 changes: 7 additions & 0 deletions FlagsmithClient/Classes/Traits.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,11 @@ import Foundation
public struct Traits: Codable, Sendable {
public let traits: [Trait]
public let identifier: String?
public let flags: [Flag]

init(traits: [Trait], identifier: String?, flags: [Flag] = []) {
self.traits = traits
self.identifier = identifier
self.flags = flags
}
}
3 changes: 2 additions & 1 deletion FlagsmithClient/Tests/RouterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ final class RouterTests: FlagsmithClientTestCase {
"trait_value" : 42
}
],
"identifier" : "A1B2C3D4"
"identifier" : "A1B2C3D4",
"flags": []
}
""".json(using: .utf8)
let body = try request.httpBody.json()
Expand Down