Refactor interaction mutex to be simpler and more consistent #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketonks-form3
force-pushed
the
mike-interaction-mutex
branch
2 times, most recently
from
775c6d2 to
c3029b4
Compare
The interaction struct contains a mix of symc.Map and atomic.Value. In preparation for adding another element which also requires locking, for read / write operations, refactor to use a shared sync.RWMutex. Note planned PR also requires to be able to marshal the interaction object into a JSON response. Replacing these elements with simple golang constructs makes this simpler, avoiding the need to copy into another response struct.
miketonks-form3
force-pushed
the
mike-interaction-mutex
branch
from
c3029b4 to
0027352
Compare
georgijd-form3
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction struct contains a mix of
sync.Mapandatomic.Value.Related to: #28
In preparation for adding another element which also requires locking, for read / write operations, refactor to use a shared
sync.RWMutex.Note planned PR also requires to be able to marshal the interaction object into a JSON response. Replacing these elements with simple golang constructs makes this simpler, avoiding the need to copy into another response struct.