refactor: Remove admin server #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin server is only used for internal tests and makes the setup sequence unnecessarily complex. In preparation for another PR to add MTLS support, we are removing it and changing the tests to start a new proxy each time instead of using the admin end point.
andykuszyk-form3
approved these changes
Jan 26, 2023
|
It's a good question @andykuszyk-form3 : Looks like it might be TLS not MTLS but implementation wise this doesn't make much difference. I added some notes to the investment-time ticket where we are tracking this: https://github.com/form3tech/investment-time-project/issues/62 There was some discussion around how we use TLS and authentication in TCH-RTP to talk to the form3 apis, but in our development setup we just use plain old HTTP. Which means we don't actually test the TLS stuff. I think the current authentication setup using token endpoint is not the ideal future path, so we're expecting some future changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin server is only used for internal tests and makes the setup sequence unnecessarily complex.
In preparation for another PR to add MTLS support, we are removing it and changing the tests to start a new proxy each time instead of using the admin end point.