feat: Pass request to pact mock server if no interaction found #44
Conversation
nicholas-lebrun-form3
force-pushed
the
nl-pass-requests-if-unrecognized
branch
3 times, most recently
from
879dd95 to
792bed8
Compare
The pact-proxy would previously return an error to the caller when an endpoint was invoked that did not match any interaction URLs. This prevents the pact mock server from correctly receiving unexpected requests. To allow pact mock server to receive unexpected requests, so it can report them in the verification endpoint, a new configuration was added. Setting the env var REJECT_UNRECOGNIZED_INTERACTIONS to false will result in the requests being passed to the pact mock service instead of rejecting them at the pact-proxy level. The default value of this is set to true so that the default behaviour of pact-proxy remains unchanged. Clients must opt-into this behaviour when deploying pact-proxy.
nicholas-lebrun-form3
force-pushed
the
nl-pass-requests-if-unrecognized
branch
from
792bed8 to
ea7f451
Compare
| @@ -13,6 +13,9 @@ func NewFromEnv() (pactproxy.Config, error) { | |||
| ctx := context.Background() | |||
|
|
|||
| var config pactproxy.Config | |||
|
|
|||
| config.RejectUnrecognizedInteractions = true | |||
There was a problem hiding this comment.
It feels like it might be more safe to flip the logic here. i.e. have the flag be AllowUnrecognizedInteractions.
That way the effect of not setting the field at all is the same as the existing functionality, and this won't be a breaking change if (for whatever reason) a caller is manually constructing a pactproxy.Config instead of using NewFromEnv.
internal/..., ignore me.
There was a problem hiding this comment.
I do agree it's a bit confusing that the logic is flipped. I chose to do this because I was not satisfied with names I came up for the variable. Happy to change it if we come up with a good name.
What do you think of ForwardUnrecognisedRequests? I thought of it at first but thought it was unclear where they would be forwarded to.
There was a problem hiding this comment.
I think that's better, I went ahead and made the change.
nicholas-lebrun-form3
changed the title
pact-proxyreturns an error to the caller when an endpoint is invoked that does not match any interaction URLs. This prevents the pact mock server from correctly receiving unexpected requests.A new env variable is added to allow passing unrecognised requests to pact mock server. This in turns allows us to retreive unexpected requests when issuing a verification GET request.
This change is opt-in via the env var to preserve the default behaviour of
pact-proxyin existing repositories.