feat: Add interaction not found error #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interactiond details endpoint previously replied with a 400 if an interaction was not found. This is changed to a 404. PactProxy now returns a defined error when a 404 is received from that endpoint, so that dependent tests can verify that the details were not returned due to the interaction not existing. This allows tests using pact proxy to verify that a certain pact interaction was not registered with pact-proxy and gives confidence that the endpoint was not invoked.
rossmcf3
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction details endpoint previously replied with a 400 if an interaction was not found. This PR changes it to a 404.
PactProxy now returns a defined error when a 404 is received from that endpoint, so that dependent tests can verify that the details were not returned due to the interaction not existing.
This allows tests using pact proxy to verify that a certain pact interaction was not registered with pact-proxy and gives confidence that the endpoint was not invoked.