fixing custom formats by string #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
+1 |
| @@ -97,7 +97,7 @@ See the accompanying LICENSE file for terms. | |||
|
|
|||
| if (formatOptions) { | |||
| if (typeof formatOptions === 'string') { | |||
| formatOptions = intlGet('formats.date.' + format, options); | |||
| formatOptions = intlGet('formats.date.' + formatOptions, options); | |||
There was a problem hiding this comment.
So this was just a copy/paste error then that was causing it to not work?
There was a problem hiding this comment.
probably a renaming process, but essentially yes, jshint reported the issue when I was copy and pasting this into the react-intl. I wonder why it didn't do it in this repo, will investigate more.
caridy
added a commit
that referenced
this pull request
Apr 28, 2014
|
+v0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the option to pass a second argument as string to select a custom formatter:
It also fixes the message format for something like this:
where
foois a number formatter, andbaris a data formatter.