Libunwind update + toolchain verification #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianCX
force-pushed
the
acruceru/174-libunwind
branch
from
8d0c3c4 to
3802a98
Compare
Pagten
approved these changes
Apr 24, 2020
| } | ||
|
|
||
| // According to entry.S in rust-lang 'desc - toolchain version number, 32-bit LE' | ||
| let version : u32 = ((desc[0] as u32) << 0) + ((desc[1] as u32) << 8) + ((desc[2] as u32) << 16) + ((desc[3] as u32) << 24); |
There was a problem hiding this comment.
You could write this as let version = u32::from_le_bytes(desc.try_into().unwrap());. The unwrap is justified by the check in line 200.
There was a problem hiding this comment.
Absolutely, definitely use that function instead of manually bitshifting
Goirad
reviewed
Apr 24, 2020
| if let (Some(EH_FRM_HDR_BASE), Some(EH_FRM_HDR_SIZE)) = (syms.EH_FRM_HDR_BASE, syms.EH_FRM_HDR_SIZE) { | ||
| check_size!(EH_FRM_HDR_BASE == 8); | ||
| check_size!(EH_FRM_HDR_SIZE == 8); | ||
| } |
There was a problem hiding this comment.
Minor thing, but I believe it is standard practice to put the else on the same line as the closing bracket
Goirad
reviewed
Apr 24, 2020
| check_size!(EH_FRM_HDR_LEN == 8); | ||
| } | ||
| else { | ||
| bail!("Missing EH Frame header symbols, application must either have (EH_FRM_HDR_BASE/EH_FRM_HDR_SIZE) or (EH_FRM_OFFSET, EH_FRM_LEN, EH_FRM_HDR_OFFSET, EH_FRM_HDR_LEN"); |
There was a problem hiding this comment.
I don't like that this message isn't more specific about what is missing, but I can't think of an elegant way of adding that specificity
There was a problem hiding this comment.
I tried to improve on it, if you have other suggestions let me know
|
bors r=pagten |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are needed to: