Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for examples #313

Closed
wants to merge 1 commit into from
Closed

Fix build for examples #313

wants to merge 1 commit into from

Conversation

AdrianCX
Copy link
Contributor

Versions must be in sync for examples and em-app.

todo: add the examples to bors

@AdrianCX AdrianCX requested a review from Pagten January 22, 2021 08:11
Pagten
Pagten previously approved these changes Jan 22, 2021
@Pagten
Copy link
Contributor

Pagten commented Jan 22, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 22, 2021
313: Fix build for examples r=Pagten a=AdrianCX

Versions must be in sync for examples and em-app.

todo: add the examples to bors

Co-authored-by: Adrian Cruceru <[email protected]>
@jethrogb
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Jan 22, 2021

Canceled.

@jethrogb
Copy link
Member

If these can break randomly, let's add them to CI.

@AdrianCX AdrianCX force-pushed the acruceru/update-examples branch from 7bbe210 to 27dba3c Compare January 25, 2021 09:21
@Taowyoo
Copy link
Collaborator

Taowyoo commented Apr 12, 2024

This PR is out of date.
I create issue for tracking the examples fixing work: #576

@Taowyoo Taowyoo closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants