-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changed the UI for emojis and added the button to navigation to draw badge. #1165
Conversation
Reviewer's Guide by SourceryThis pull request modifies the emoji UI and adds a button to navigate to the draw badge screen. The emoji grid has been updated to include a button that navigates to the draw badge screen. The emoji grid has also been updated to have a different layout. Sequence diagram for emoji selection and draw badge navigationsequenceDiagram
actor User
participant Grid as VectorGridView
participant Provider as ImageProvider
participant Nav as Navigator
User->>Grid: Tap emoji
Grid->>Provider: insertInlineImage(key)
User->>Grid: Tap add button
Grid->>Nav: pushNamed('/drawBadge')
Class diagram for VectorGridView widget changesclassDiagram
class VectorGridView {
-_VectorGridViewState createState()
}
class _VectorGridViewState {
+Widget build(BuildContext context)
}
note for _VectorGridViewState "Modified grid layout:
- Changed crossAxisCount to 9
- Added navigation button
- Updated padding"
VectorGridView --> _VectorGridViewState
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jhalakupadhyay - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting magic numbers (grid columns=9, padding=2.0) into named constants for better maintainability
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/12966568130/artifacts/2485327720 |
#1133
Summary by Sourcery
New Features: