Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed the UI for emojis and added the button to navigation to draw badge. #1165

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

Jhalakupadhyay
Copy link
Contributor

@Jhalakupadhyay Jhalakupadhyay commented Jan 25, 2025

#1133

  • Added the remaining vectors.
  • increased the column count to 9 each row which changes the row count to 5.
  • added the icon to navigate to draw badge screen directly from the vector view.

vector_grid_view_changes

Summary by Sourcery

New Features:

  • Added a "Draw Badge" button to the navigation bar.

Copy link
Contributor

sourcery-ai bot commented Jan 25, 2025

Reviewer's Guide by Sourcery

This pull request modifies the emoji UI and adds a button to navigate to the draw badge screen. The emoji grid has been updated to include a button that navigates to the draw badge screen. The emoji grid has also been updated to have a different layout.

Sequence diagram for emoji selection and draw badge navigation

sequenceDiagram
  actor User
  participant Grid as VectorGridView
  participant Provider as ImageProvider
  participant Nav as Navigator

  User->>Grid: Tap emoji
  Grid->>Provider: insertInlineImage(key)
  User->>Grid: Tap add button
  Grid->>Nav: pushNamed('/drawBadge')
Loading

Class diagram for VectorGridView widget changes

classDiagram
  class VectorGridView {
    -_VectorGridViewState createState()
  }
  class _VectorGridViewState {
    +Widget build(BuildContext context)
  }
  note for _VectorGridViewState "Modified grid layout:
  - Changed crossAxisCount to 9
  - Added navigation button
  - Updated padding"
  VectorGridView --> _VectorGridViewState
Loading

File-Level Changes

Change Details Files
Updated the emoji grid to include a button that navigates to the draw badge screen.
  • Added a GestureDetector to navigate to the draw badge screen.
  • Added a new item to the grid view to display the navigation button.
  • Added an Icon to the navigation button.
  • Updated the grid view to have 9 columns.
lib/view/widgets/vectorview.dart
Updated the emoji grid layout.
  • Updated the grid view to have 9 columns.
  • Updated the padding of the emoji items.
lib/view/widgets/vectorview.dart
Updated the emoji popup background color.
  • Changed the background color of the emoji popup to grey.
lib/view/homescreen.dart
Added new vector assets.
  • Added new vector assets.
assets/vectors/clip_apple.svg
assets/vectors/clip_arrow_left.svg
assets/vectors/clip_clock_nine.svg
assets/vectors/clip_dustbin.svg
assets/vectors/clip_home.svg
Removed old vector assets.
  • Removed old vector assets.
assets/vectors/clip_clock_nine_oclock.SVG
assets/vectors/clip_clock_six_oclock.SVG
assets/vectors/clip_clock_twelve_oclock.SVG

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jhalakupadhyay - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting magic numbers (grid columns=9, padding=2.0) into named constants for better maintainability
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@adityastic adityastic merged commit 4f17ab0 into fossasia:flutter_app Jan 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants