Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to edit badges #382

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

adityastic
Copy link
Collaborator

@adityastic adityastic commented Jun 16, 2019

Fixes #261

Changes:

  • redirect users to draw layout

Screenshots:
Before:

On Edit:

After Edit:

On Save:

On Save Preview:

@adityastic adityastic changed the title WIP feat: option to edit badges feat: redirect users to edit badges Jun 16, 2019
@auto-label auto-label bot added the feature label Jun 16, 2019
@adityastic adityastic changed the title feat: redirect users to edit badges feat: redirect users to draw layout on edit badge Jun 16, 2019
@adityastic adityastic force-pushed the patch-261 branch 2 times, most recently from 013a13b to 44845b5 Compare June 16, 2019 10:30
@adityastic adityastic changed the title feat: redirect users to draw layout on edit badge feat: option to edit badges Jun 16, 2019
@adityastic adityastic force-pushed the patch-261 branch 2 times, most recently from 7bff938 to 1faeed7 Compare June 16, 2019 11:12
@adityastic
Copy link
Collaborator Author

@mariobehling @yashk2000 @iamareebjamal review

@iamareebjamal
Copy link
Member

PRF

@adityastic
Copy link
Collaborator Author

@iamareebjamal hey areeb, I'm not sure what am I missing from the format. Proper name ✓, Single Commit ✓, Mentioning Fixed Issue ✓, Screenshot for change ✓. Is there anything more?

@mariobehling
Copy link
Member

Maybe better provide single screenshots in future. This Gif is too fast. Difficult to see.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the "Edit Button" directly on the big area itself. Avoid additional popups. No need to get the user to make more clicks. Add a button directly next to all the buttons on the specific badge descriptive area.

@adityastic
Copy link
Collaborator Author

adityastic commented Jun 17, 2019

@mariobehling got it, let me update it accordingly

@adityastic
Copy link
Collaborator Author

@mariobehling @iamareebjamal Updated with screenshots, have a look

@mariobehling
Copy link
Member

Nice. Thank you! Let's try this in production.

@mariobehling mariobehling merged commit 4c89e5a into fossasia:development Jun 17, 2019
@adityastic adityastic deleted the patch-261 branch June 18, 2019 07:24
@adityastic adityastic self-assigned this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an Edit button for saved badges
3 participants