-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to edit badges #382
Conversation
013a13b
to
44845b5
Compare
7bff938
to
1faeed7
Compare
PRF |
@iamareebjamal hey areeb, I'm not sure what am I missing from the format. Proper name ✓, Single Commit ✓, Mentioning Fixed Issue ✓, Screenshot for change ✓. Is there anything more? |
Maybe better provide single screenshots in future. This Gif is too fast. Difficult to see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the "Edit Button" directly on the big area itself. Avoid additional popups. No need to get the user to make more clicks. Add a button directly next to all the buttons on the specific badge descriptive area.
@mariobehling got it, let me update it accordingly |
@mariobehling @iamareebjamal Updated with screenshots, have a look |
Nice. Thank you! Let's try this in production. |
Fixes #261
Changes:
Screenshots:
Before:
On Edit:
After Edit:
On Save:
On Save Preview: