feat: draw clipart option in drawer #388
Conversation
adityastic
force-pushed
the
patch-385
branch
3 times, most recently
from
ae626fb to
ed6f06e
Compare
adityastic
changed the title
adityastic
force-pushed
the
patch-385
branch
3 times, most recently
from
28096f6 to
b911f0d
Compare
|
Awesome! Please resolve conflicts. |
|
@adityastic Please add a "Draw Clipart Icon" at the end of the clipart list. This button should direct to the "Draw Clipart screen.
|
|
@mariobehling On it |
| if (drawableInfo.image is VectorDrawable) | ||
| ImageUtils.vectorToBitmap(drawableInfo.image) | ||
| else | ||
| (drawableInfo.image as BitmapDrawable).bitmap, 70)), 0, strToAppend.length, 33) |
There was a problem hiding this comment.
use smart cast instead: drawableInfo.image is BitmapDrawable
There was a problem hiding this comment.
There are 3 more unsafe casts like that.
There was a problem hiding this comment.
There are 3 more unsafe casts like that.
on it
There was a problem hiding this comment.
done, please review
|
|
||
| <ImageView | ||
| android:layout_width="48dp" | ||
| android:layout_height="48dp" |
There was a problem hiding this comment.
Dimensions should define inside dimentsion reqources file.
There was a problem hiding this comment.
@liveHarshit yes updated all with the same
| DrawFragment() | ||
| } | ||
|
|
||
| private val viewModel by viewModel<DrawViewModel>() |
There was a problem hiding this comment.
Too generic, it can be drawViewModel
adityastic
force-pushed
the
patch-385
branch
2 times, most recently
from
95270e9 to
2c0c3aa
Compare
|
@liveHarshit updated |
|
@mariobehling here is the update. Screenshot of the update: |
|
@liveHarshit updated with the rest, please review |
| android:layout_alignParentTop="true" | ||
| android:layout_centerInParent="true" | ||
| android:layout_marginStart="50dp" | ||
| android:layout_marginEnd="50dp" |
There was a problem hiding this comment.
updated, @liveHarshit review
| android:layout_height="wrap_content" | ||
| android:layout_alignParentBottom="true" | ||
| android:orientation="horizontal" | ||
| android:padding="10dp"> |
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="10dp" |
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="10dp" |
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="10dp" |
|
@mariobehling @iamareebjamal peer review done |
|
@mariobehling ready to merge |
Fixes #385
Screenshots:
On Drawer:
After Opening:
Drawn and Saved:
ClipArts get Updated: