Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove before-install script #399

Merged
merged 1 commit into from
Jun 21, 2019
Merged

chore: remove before-install script #399

merged 1 commit into from
Jun 21, 2019

Conversation

adityastic
Copy link
Collaborator

Fixes #398

Changes:

  • Removed Before Script

@auto-label auto-label bot added the chore label Jun 20, 2019
@adityastic
Copy link
Collaborator Author

@CloudyPadmal @iamareebjamal Please Review

GOVINDDIXIT
GOVINDDIXIT reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@GOVINDDIXIT GOVINDDIXIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adityastic the issue is already closed. Can you pls look into it?

@adityastic
Copy link
Collaborator Author

@GOVINDDIXIT yes, I have commented on the issue already. Waiting for Areeb's reply

@iamareebjamal iamareebjamal merged commit 52223ab into fossasia:development Jun 21, 2019
@adityastic adityastic deleted the patch-test-yaml branch July 5, 2019 01:45
@adityastic adityastic self-assigned this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOVINDDIXIT GOVINDDIXIT GOVINDDIXIT left review comments

@yashk2000 yashk2000 Awaiting requested review from yashk2000

Assignees

@adityastic adityastic

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

before-install script can be removed from yaml
3 participants
@adityastic @GOVINDDIXIT @iamareebjamal