feat: ability to show badges #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
force-pushed
the
patch-405
branch
2 times, most recently
from
bffb61a to
fcfd9a9
Compare
yashk2000
reviewed
Jun 25, 2019
| @@ -89,4 +89,5 @@ | |||
| <string name="drawer_draw_badge">画剪贴画</string> | |||
| <string name="clipart_saved_success">ClipArt已成功保存</string> | |||
| <string name="clipart_saved_error">保存剪贴画时出错</string> | |||
| <string name="drawer_saved_cliparts">Saved Cliparts</string> | |||
There was a problem hiding this comment.
Shouldn't it be in chinese here?
There was a problem hiding this comment.
Yes, but I usually batch translate before releasing a version on playstore xD.
There was a problem hiding this comment.
@iamareebjamal changing
yashk2000
approved these changes
Jun 25, 2019
|
@mariobehling @iamareebjamal Peer Review done. Please Review |
|
@iamareebjamal updated. |
iamareebjamal
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
Changes:
Screenshots for the change:
In Drawer:
Section: