Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force stop when rejected permission #418

Merged
merged 1 commit into from
Jun 29, 2019
Merged

fix: force stop when rejected permission #418

merged 1 commit into from
Jun 29, 2019

Conversation

adityastic
Copy link
Collaborator

@adityastic adityastic commented Jun 28, 2019 •
edited
Loading

Fixes #416

Changes:

  • Added Permission Check Before saving badge

Screenshots for the change:
4161

@auto-label auto-label bot added the fix label Jun 28, 2019
@iamareebjamal
Copy link
Member

If user allows the permission, resume from there

@adityastic
Copy link
Collaborator Author

If user allows the permission, resume from there

Sure

@adityastic
Copy link
Collaborator Author

@iamareebjamal review

@mariobehling mariobehling merged commit c31c5af into fossasia:development Jun 29, 2019
@adityastic adityastic deleted the 416 branch July 5, 2019 01:44
@adityastic adityastic self-assigned this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@mariobehling mariobehling mariobehling approved these changes

@yashk2000 yashk2000 Awaiting requested review from yashk2000

Assignees

@adityastic adityastic

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge Magic v1.2.0 - Application suddenly stops when saving "Badge"
3 participants
@adityastic @iamareebjamal @mariobehling