Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to delete cliparts #419

Merged
merged 1 commit into from
Jun 29, 2019
Merged

feat: ability to delete cliparts #419

merged 1 commit into from
Jun 29, 2019

Conversation

adityastic
Copy link
Collaborator

@adityastic adityastic commented Jun 28, 2019 •
edited
Loading

Fixes #409

Changes:

  • Cliparts can now be deleted

Screenshots for the change:
Saved Cliparts:

After Delete:

Changed Cliparts:

@auto-label auto-label bot added the feature label Jun 28, 2019
@adityastic adityastic marked this pull request as ready for review June 28, 2019 14:06
@adityastic
Copy link
Collaborator Author

@iamareebjamal review the changes, tell me if there is some better approach with data binding

@iamareebjamal iamareebjamal merged commit 7f1d7a2 into fossasia:development Jun 29, 2019
@adityastic adityastic mentioned this pull request Jun 30, 2019
Closed
@adityastic adityastic deleted the 409 branch July 5, 2019 01:45
@adityastic adityastic self-assigned this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2000 yashk2000 yashk2000 approved these changes

@mariobehling mariobehling mariobehling approved these changes

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

Assignees

@adityastic adityastic

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ability to delete cliparts
4 participants
@adityastic @mariobehling @yashk2000 @iamareebjamal