chore: added aab support and improved script #428
Conversation
adityastic
force-pushed
the
apk-improvement
branch
from
780a9bf to
65d6efa
Compare
adityastic
force-pushed
the
apk-improvement
branch
3 times, most recently
from
aae87bb to
ce82fac
Compare
scripts/prep-key.sh
Outdated
| @@ -4,7 +4,7 @@ set -e | |||
| export DEPLOY_BRANCH=${DEPLOY_BRANCH:-development} | |||
| export PUBLISH_BRANCH=${PUBLISH_BRANCH:-master} | |||
|
|
|||
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ] || ! [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" -o "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then | |||
| if [ "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ] || ! [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" -o "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then | |||
There was a problem hiding this comment.
Revert so there is a common way of handling things, may remove the condition from .travis.yml
There was a problem hiding this comment.
sure, it will be consistent
scripts/upload-apk.sh
Outdated
|
|
||
| #removing unused apps | ||
| for file in app*; do | ||
| if [[ ${file} =~ "unsigned" || ${file} =~ "unaligned" ]]; then | ||
| rm ${file} | ||
| elif [[ ${file} =~ ".aab" ]]; then |
There was a problem hiding this comment.
Master and dev aab should be separate
There was a problem hiding this comment.
Areeb, aab is a publishing format, hence it is of no use to the normal users. Why do you want to keep in the apk branch?
There was a problem hiding this comment.
that is the reason I just used it to push the app to playstore and keep the release and debug apk's in the apk branch.
There was a problem hiding this comment.
It is of use to me. Because I want to debug what was sent to play store if something goes wrong.
Normal users use fdroid or play store to download the APK. I and fellow developers and maintainers use the APK branch
There was a problem hiding this comment.
nvm, ill do it right away
scripts/upload-apk.sh
Outdated
| fastlane supply --apk app.aab --track alpha --json_key fastlane.json --package_name $PACKAGE_NAME |
scripts/upload-apk.sh
Outdated
| @@ -46,6 +45,7 @@ git checkout --orphan temporary | |||
|
|
|||
| # Add generated APK | |||
| git add --all . | |||
| git rm --cached app.aab | |||
adityastic
force-pushed
the
apk-improvement
branch
2 times, most recently
from
70a0c3c to
f0e4b2a
Compare
adityastic
force-pushed
the
apk-improvement
branch
from
f0e4b2a to
747ac19
Compare
Fixes #427
Changes: