chore: improved fastlane usage and scripts #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
requested review from
mariobehling,
iamareebjamal,
CloudyPadmal,
GOVINDDIXIT,
ShridharGoel and
yashk2000
scripts/prep-key.sh
Outdated
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ] || ! [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" -o "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then | ||
| echo "We decrypt key only for pushes to the master or development branch and not PRs. So, skip." | ||
| # Check if it is not a Pull Request Build | ||
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ]; then |
There was a problem hiding this comment.
This will decrypt key for all branches
scripts/upload-apk.sh
Outdated
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ] || ! [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" -o "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then | ||
| echo "We upload apk only for changes in development or master, and not PRs. So, let's skip this shall we ? :)" | ||
| # Check if it is not a Pull Request Build | ||
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge-magic-android" ]; then |
iamareebjamal
suggested changes
Jul 28, 2019
adityastic
force-pushed
the
fastlane-fix
branch
4 times, most recently
from
0562dc1 to
6cf0027
Compare
|
@iamareebjamal have a look |
scripts/upload-apk.sh
Outdated
| @@ -12,7 +12,9 @@ if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/badge | |||
| exit 0 | |||
| fi | |||
|
|
|||
| ./gradlew bundleRelease | |||
| if [[ "$TRAVIS_BRANCH" != "$PUBLISH_BRANCH" ]]; then | |||
There was a problem hiding this comment.
We always want to build aab
There was a problem hiding this comment.
great, I've removed the unsigned and unaligned conditions as well as they are not being created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
Changes: