Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve Edit Clipart Screen - Size and Buttons #483

Merged
merged 1 commit into from
Sep 15, 2019
Merged

feat: Improve Edit Clipart Screen - Size and Buttons #483

merged 1 commit into from
Sep 15, 2019

Conversation

adityastic
Copy link
Collaborator

Fixes #481

Changes

  • fixed dimens for buttons

Screenshots for the change:
gg

@auto-label auto-label bot added the fix label Aug 19, 2019
@adityastic adityastic self-assigned this Aug 19, 2019
@adityastic adityastic changed the title fix: Improve Edit Clipart Screen - Size and Buttons feat: Improve Edit Clipart Screen - Size and Buttons Aug 19, 2019
@auto-label auto-label bot added feature and removed fix labels Aug 19, 2019
@yashk2000
Copy link
Member

yashk2000 commented Aug 19, 2019 •
edited
Loading

@adityastic how will it look if we shift the button to directly under the badge? Like right now they are a bit to the left of the badge.

@adityastic
Copy link
Collaborator Author

@yashk2000 yes we can. @mariobehling suggestions?

@mariobehling
Copy link
Member

Please increase width and height of badge area as shown in the image below.

63246419-ee2cae80-c262-11e9-97d5-f649392f1eb3

@adityastic
Copy link
Collaborator Author

@mariobehling if we increase the height and width of the badge, it will lead to two cases:

  1. The buttons won't have enough space to be visible
  2. The badge will get streched

Currently the badge adjusts itself to fit it's height regardless of the width untill the width is less than the available width. Please update me accordingly

@mariobehling
Copy link
Member

mariobehling commented Aug 22, 2019 •
edited
Loading

Please move the buttons to the bottom of the screen and use the free space to increase the badge. Don't stretch or squeeze it, just increase the dimension in proportion to the max possible.

@mariobehling
Copy link
Member

@adityastic Please finalize this PR.

@adityastic
Copy link
Collaborator Author

@iamareebjamal plz review

@adityastic adityastic merged commit b23aed6 into fossasia:development Sep 15, 2019
@adityastic adityastic deleted the patch-481 branch September 15, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@mariobehling mariobehling Awaiting requested review from mariobehling

@yashk2000 yashk2000 Awaiting requested review from yashk2000

Assignees

@adityastic adityastic

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Edit Clipart Screen - Size and Buttons
4 participants
@adityastic @yashk2000 @mariobehling @iamareebjamal