Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore : enabling bundler caching #496

Merged
merged 1 commit into from
Sep 14, 2019
Merged

chore : enabling bundler caching #496

merged 1 commit into from
Sep 14, 2019

Conversation

ruplsingh
Copy link
Contributor

Fixes #492
Changes:

  • enabled bundler

@ruplsingh
Copy link
Contributor Author

@adityastic , @iamareebjamal please review

@adityastic
Copy link
Collaborator

Please follow symantic pr naming https://github.com/probot/semantic-pull-requests/blob/master/README.md

@ruplsingh ruplsingh changed the title enabling bundler caching chore : enabling bundler caching Sep 7, 2019
@ruplsingh
Copy link
Contributor Author

updated pr title @adityastic

@adityastic
Copy link
Collaborator

Please update the commit title as well

adityastic
adityastic reviewed Sep 14, 2019
View reviewed changes
Copy link
Collaborator

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a cache section in travis, try to accommodate the script inside that section rather than creating another cache section in travis

@adityastic
Copy link
Collaborator

@klutzayyyy please squash commits into a single commit https://github.com/fossasia/pslab-android#how-to-git-squash

@adityastic adityastic merged commit 88da920 into fossasia:development Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityastic adityastic adityastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Script by Caching Bundler
2 participants
@ruplsingh @adityastic