feat: share app details on social platforms #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
reviewed
Nov 17, 2019
app/src/main/res/values/strings.xml
Outdated
| @@ -103,4 +104,6 @@ | |||
| <string name="clipart_saved_error">Error in saving Clipart</string> | |||
| <string name="drawer_saved_cliparts">Saved Cliparts</string> | |||
| <string name="no_gps_enabled">No GPS Found, Please Enable GPS from Settings</string> | |||
|
|
|||
| <string name="share_msg">Badge Magic is an Android app to control LED name badges. This app provides features to portray names, graphics and simple animations on LED badges. \nI really loved this application, even you can download it from below link \nhttps://play.google.com/store/apps/details?id=org.fossasia.badgemagic</string> | |||
There was a problem hiding this comment.
I think the "I really love this application" part is not needed over here. Please frame a better message without it.
yashk2000
suggested changes
Nov 17, 2019
| @@ -122,6 +122,13 @@ class DrawerActivity : BaseActivity(), NavigationView.OnNavigationItemSelectedLi | |||
| R.id.buy -> { | |||
| startActivity(Intent(Intent.ACTION_VIEW, Uri.parse("https://sg.pslab.io"))) | |||
| } | |||
| R.id.share_app_details -> { | |||
| val shareIntent = Intent() | |||
| shareIntent.type = getString(R.string.share_msg) | |||
There was a problem hiding this comment.
Yeah i was testing what was wrong
| shareIntent.type = getString(R.string.share_msg) | ||
| shareIntent.action = Intent.ACTION_SEND | ||
| shareIntent.putExtra(Intent.EXTRA_TEXT, getString(R.string.share_msg)) | ||
| startActivity(Intent.createChooser(shareIntent, getString(R.string.share_msg))) |
There was a problem hiding this comment.
Why are you setting title to share_msg
|
Now the travis build is fixed @yashk2000. Can you please merge it |
adityastic
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
@tanmayrauth well done, you're pull request will help people spread awareness about our app. We also follow semantic naming while submitting a pr. We can name this pr with a feat prefix as this is a new feature, and the description is perfect. Hence, it can be renamed to "feat: share app details on social platforms"
adityastic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat #533
It will be a button in navigation drawer that will help users to share details about the application across various social media. So that their friends can also get to know about this app and download it.
Changes: changes were made in navigation drawer of the the app. A new share button is added.
Screenshots for the change:
