feat: app specific directory storage #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityastic please review. |
adityastic
reviewed
Dec 15, 2019
|
@adityastic changed one. |
adityastic
reviewed
Dec 17, 2019
| @@ -19,12 +19,12 @@ import org.fossasia.badgemagic.data.fragments.CONF_SPEED | |||
| import org.fossasia.badgemagic.data.fragments.ConfigInfo | |||
| import org.json.JSONObject | |||
|
|
|||
| object StorageUtils { | |||
| class StorageUtils(val context: Context) { | |||
| private val EXTERNAL_STORAGE_DIRECTORY = "${Environment.getExternalStorageDirectory() | |||
There was a problem hiding this comment.
try to change Environment.getExternalStorageDirectory to app specific directory code now
|
@adityastic changed the Environment.getExternalStorageDirectory to app-specific directory code :)
|
|
@refactor-droidyy yes, you need to pass the object in the async task |
|
@adityastic everything is working fine now. |
adityastic
changed the title
adityastic
approved these changes
Dec 18, 2019
|
@adityastic once again thank you very much I didn't know much about injecting dependency managing singletons and its vast use. But now with this PR and your guidance I really learned a lot. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544 Shift to App-Specific Directory for storing Badge and Clipart's