Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverse listing of saved badges #570

Merged
merged 4 commits into from
Dec 26, 2019
Merged

fix: reverse listing of saved badges #570

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4176e42
reverse orientation
rohitverma1999hack Dec 23, 2019
a184337
Merge branch 'development' of https://github.com/fossasia/badge-magic…
rohitverma1999hack Dec 26, 2019
884193e
sorted according to date
rohitverma1999hack Dec 26, 2019
eac8256
change required ones
rohitverma1999hack Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/main/java/org/fossasia/badgemagic/util/StorageUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ class StorageUtils(val context: Context) {

externalStorageDir?.let {
val files = File(externalStorageDir).listFiles() ?: return list
files.sortWith(Comparator<File> { a, b ->
when {
a.lastModified() - b.lastModified() > 0 -> 1
a.lastModified() - b.lastModified() < 0 -> -1
else -> 0
}
Copy link
Member

@iamareebjamal iamareebjamal Dec 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

return a.lastModified() - b.lastModified()

})
for (i in files.indices) {
if (getFileExtension(files[i].name) == badgeExt) {
val json = files[i].readText()
Expand All @@ -59,7 +66,7 @@ class StorageUtils(val context: Context) {
}
}
}
return list
return list.asReversed()
}

private fun getFileExtension(name: String): String {
Expand Down