-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiplatform module for Android and iOS #595
Conversation
0562064
to
6ea54c4
Compare
@iamareebjamal I plan on creating another branch to push the latest SharedFramework which we would download when compiling badge-magic-ios , let me know your suggestions on this |
Sounds good but why not do it in one repo |
yes, that is an amazing idea, we can shift iOS directly here and maintain both the apps right here itself |
@iamareebjamal we would then have to manage travis to use macOS and manually download android sdk, gradle, jdk and the rest of things inside a android docker. Let me know your thoughts, If it is worth the effort |
You can use environments to differentiate between both. Not sure how easy it is in Travis but here is an example of GitHub Actions - https://github.com/korlibs/klock Another: https://travis-ci.com/fossasia/flask-rest-jsonapi/builds/130125460 |
@iamareebjamal the catch with environments is that they run concurrently, we might want to synchronously run our project on an android image to build our iOS-framework then run it on OS X image to build iOS with the built framework. |
8b7b69e
to
418e58c
Compare
@iamareebjamal nvm, I managed to sync it HAHA |
9ff340b
to
980e9c5
Compare
@iamareebjamal Changes:
Next Steps: Add iOS project tomorrow |
980e9c5
to
9a940db
Compare
@iamareebjamal please review |
@@ -10,10 +10,10 @@ import androidx.appcompat.widget.AppCompatImageView | |||
import androidx.core.content.ContextCompat | |||
import androidx.recyclerview.widget.RecyclerView | |||
import com.google.android.material.chip.Chip | |||
import data.BadgeConfig | |||
import data.ConfigInfo | |||
import helpers.JSONHelper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not prepending org.fossasia.badgemagic and using same package structure in common module as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it would be perfect
9a940db
to
d514163
Compare
d514163
to
bb4b7ce
Compare
Fixes #575