chore: shift ios project to this project #606
Conversation
adityastic
changed the title
adityastic
force-pushed
the
patch-604
branch
3 times, most recently
from
83ff844 to
69bb2f9
Compare
adityastic
changed the title
adityastic
force-pushed
the
patch-604
branch
12 times, most recently
from
c43c956 to
8bccef8
Compare
|
@iamareebjamal travis is one hell of a mess. It does not allow you to use android language on macOS image.
Let me know your thoughts on this approach. This is a workaround and I'm sure there must be a better way or we can switch to Github Workflow which might be better as a whole. |
|
@iamareebjamal if we can manage to build only the module we can solve this without issues, but for some reason even after specifying the module with the command it builds the android project which fails for some unknown reason https://travis-ci.com/fossasia/badge-magic-android/jobs/272179208. |
| # ----------- | ||
| # ----------- | ||
| # Remove Project from gradle.settings | ||
| - echo "include ':BadgeMagicModule'" > settings.gradle |
There was a problem hiding this comment.
@iamareebjamal that's the hack for now
adityastic
changed the title
|
Merge after changing the PR title |
|
The build is failing because gradle is built on JDK 12 and JDK 13 is installed on the platform. gradle only supports JDK <= 12 So, if you can use that, it'll fix the error. But for now, this is fine. Open an issue to improve the implementation later on |
|
@iamareebjamal Yes, Even I thought the same and tried all jdk's from 8 to 12, all failed because of Kotlin NullPointerException in Databinding. Here are the links of all builds, It should not build the android project as I was specifying the module specifically, but for some reason it was. jdk8 - https://travis-ci.com/fossasia/badge-magic-android/jobs/272161844 |
adityastic
changed the title
Fixes #604