fix: remove completely location permissions #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is to satisfy Google, had been tested on Android 12 only.
adityastic
approved these changes
May 24, 2024
kienvo
added a commit
to kienvo/badgemagic-android
that referenced
this pull request
Jul 5, 2024
Changes: - revert c22c243 (fossasia#936) - only ask for Location and show Prominent Disclosure on Android 11 and below
kienvo
added a commit
to kienvo/badgemagic-android
that referenced
this pull request
Jul 6, 2024
Changes: - revert c22c243 (fossasia#936) - only ask for Location and show Prominent Disclosure on Android 11 and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Changes: remove completely location permissions
This fix is to satisfy Google, had been tested on Android 12 only.