Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fixtures after forge-std release #8302

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jun 29, 2024

Motivation

Solution

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin forge-std?

@klkvr
Copy link
Member Author

klkvr commented Jun 29, 2024

Should we pin forge-std?

I think we can pin it + add an automatic CI job to create PR bumping it on releases. don't think we'd always remember to bump it otherwise

some of the tests are also probably using forge init which always installs latest release

@DaniPopes
Copy link
Member

Let's do that in a follow-up

@DaniPopes DaniPopes merged commit e65b5b9 into master Jun 30, 2024
19 checks passed
@DaniPopes DaniPopes deleted the klkvr/fix-forge-std branch June 30, 2024 00:14
klkvr added a commit that referenced this pull request Jun 30, 2024
* chore: update fixtures after forge-std release

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants