Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev shell flake #8314

Merged
merged 1 commit into from
Jun 30, 2024
Merged

chore: update dev shell flake #8314

merged 1 commit into from
Jun 30, 2024

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jun 30, 2024

Updated to latest Rust toolchain version (v1.79). The rust overlay doesn't use flake-utils anymore. Switched to solc 0.8.23 since that's the default for the tests. Moved around the deps to be more in line with recommendations (buildInputs for things that get linked and nativeBuildInputs for what's needed during compilation only, packages for things that are not needed at compile time). libusb shouldn't be needed in the buildInputs since it's already included via the definition of the LD_LIBRARY_PATH environment variable.

Motivation

Project doesn't compile with the rust toolchain version from the lockfile.

Solution

Updated the lockfile and cleaned up the flake.

Updated to latest Rust toolchain version (v1.79). The rust overlay
doesn't use `flake-utils` anymore. Switched to solc 0.8.23 since that's
the default for the tests. Moved around the deps to be more in line with
recommendations (`buildInputs` for things that get linked and
`nativeBuildInputs` for what's needed during compilation only,
`packages` for things that are not needed at compile time).
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mattsse mattsse merged commit 21c40c7 into foundry-rs:master Jun 30, 2024
19 checks passed
@beeb beeb deleted the update-flake branch June 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants