This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Added pa11y, set up testing for twig, scss reloading #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roadmap identified in practice group:
|
amazingrando
added
Status: In Progress
Status: Passes functional review
and removed
Status: Review Needed
labels
Nov 21, 2018
amazingrando
suggested changes
Nov 21, 2018
gulp-tasks/pa11y.js
Outdated
// eslint-disable-next-line | ||
const pa11yCli = require('pa11y-reporter-cli'); | ||
|
||
// function pa11yRun(pa11yUrl, config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this commented out code be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, done. Thanks!
amazingrando
approved these changes
Nov 21, 2018
amazingrando
added
Status: Passes code review
Status: Shipit
and removed
Status: In Progress
labels
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pa11y accessibility testing on save of twig and scss files.
Pull Request Deployment
If you've never set up Emulsify Gulp for local testing, do the following:
npm link
npm link emulsify-gulp
To Test: