This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Composer installable #119
Merged
Composer installable #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccjjmartin
reviewed
Aug 8, 2017
composer.json
Outdated
| "post-install-cmd": [], | ||
| "post-update-cmd": [] | ||
| "post-install-cmd": [ | ||
| "drush emulsify" |
ccjjmartin
reviewed
Aug 8, 2017
composer.json
Outdated
| "repositories": {}, | ||
| "require": { | ||
| "drupal/components": "^1.0", | ||
| "drupal-pattern-lab/unified-twig-extensions": "dev-develop" |
There was a problem hiding this comment.
Can this be on drupal.org?
There was a problem hiding this comment.
Sounds like it will be on Packagist
ModulesUnraveled
force-pushed
the
composer-installable
branch
from
ee35256 to
333cdd2
Compare
| # Link contrib twig functions into the components directory | ||
|
|
||
| # First we need to find out whether this is inside a Drupal install or standalone Emulsify | ||
| if [ -d ../../../../vendor ] |
There was a problem hiding this comment.
I have an older Drupal install that I ran this inside of and it didn't have the /web directory. Should we make this more open-ended to handle that?
evanmwillhite
approved these changes
Aug 17, 2017
evanmwillhite
added
Status: Passes code review
Status: Passes functional review
and removed
ready for review
labels
README.md
Outdated
| 1. `composer require fourkitchens/emulsify` | ||
| 2. `cd web/themes/contrib/emulsify/` | ||
| 3. `npm install` or `yarn install` | ||
| 4. Optional (but recommeded): Create "child" theme `drush emulsify "Theme Name"` (more details below) |
There was a problem hiding this comment.
Also, is it drush emulsify "Theme Name" or drush emulsify site_machine_name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
composer installyarn install(ornpm install)To Review:
If installing Emulsify standalone:
composer installinside it, or just runcomposer create-project "fourkitchens/emulsify:dev-composer-installable" --stability dev --no-interaction emulsifyyarn upgrade && yarn install && yarn startcomponents/_twig-components/functionsIf installing inside a Drupal instance:
composer require "fourkitchens/emulsify:dev-composer-installable"cd web/themes/contrib/emulsify/yarn upgrade && yarn install && yarn startcomponents/_twig-components/functionsTodo:
The child theme needs to get these components as well. Maybe a symlink from the child themesfunctionsfolder to the one in Emulsify'svendordirectory? (Maybe emulsify should just use a symlink too, instead of copying the file.)(I think as long as the package.json is copied, along with the
scriptsfolder, the child theme will get the functions in place.)The functions are placed in the root vendor directory, notemulsify/vendorwhen installed in a Drupal instance... What do we do?(I created a script to check for the vendor directories, so it'll work in both cases)
scriptsdirectory for both regular and --slim