Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

223: Clarify image directory usage #230

Merged
merged 2 commits into from
May 14, 2018
Merged

223: Clarify image directory usage #230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b8992
readme files
May 14, 2018
6ea9b99
updated readme
May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/images/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is Pattern Lab's default images directory. We recommend putting theme images into `/images` or into a relevant component directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's specify that they're only for pattern lab. Something like:

This is Pattern Lab's default images directory. Images that only apply to the Pattern Lab instance should be placed here. e.g. One image of each dimension (portrait, landscape, square, etc.) to demonstrate the various components with images.

We recommend putting theme images into the theme's root-level /imagesdirectory or into a relevant component directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, updated.

1 change: 1 addition & 0 deletions images/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
We recommend using this directory or a relevant component directory for all theme images.