Clean up base PL styles #236
Conversation
amazingrando
added
Status: Changes Requested
Status: Passes functional review
and removed
Status: Review Needed
labels
| @@ -0,0 +1,5 @@ | |||
| main { | |||
There was a problem hiding this comment.
Should use .main instead of hanging this on the element. Could cause issues when main is used elsewhere.
| @@ -0,0 +1,82 @@ | |||
| // These styels are specifically for Pattern Lab. | |||
There was a problem hiding this comment.
Typo. Change "styels" to "styles".
|
@amazingrando I've made those changes |
ModulesUnraveled
added
Status: Review Needed
and removed
Status: Changes Requested
labels
amazingrando
added
Status: Passes code review
Status: Shipit
and removed
Status: Review Needed
labels
| } | ||
| } | ||
|
|
||
| /// Use the breakout mixin for elements that should be edge-to-edge |
There was a problem hiding this comment.
What do you think about separating all the full-width pieces out into a gist? I like the code, but this is really a project-specific need and makes the wrapper mixin a little less approachable.
There was a problem hiding this comment.
The breakout mixin doesn't affect the wrapper mixin in any way. The wrapper mixin will stay exactly the same, even if we remove the breakout mixin.
I'd like to keep the breakout in here. Maybe I just need to record a quick "Here's how to use this" video, or write a blogpost.
I don't think it's project-specific, it's just "any time you have a broad-context container (like body or main) and you need a way to have a full-width element, this is how you do it.
There was a problem hiding this comment.
No worries - it was a minor nitpick to begin with. More prescriptive than my taste for Emulsify "core," but you're right about it not simplifying the breakout mixin. I was thinking we could get rid of some of the breakout mixin args, but you're using them all anyway.
I don't think a post/video is necessary for such a small piece of code (although showing off how it was used on a client project might be cool). It might not hurt to add some CSS comments or a link to someone else's post in the code (not necessary but maybe helpful for someone who hadn't come across that technique).
| @@ -0,0 +1,9 @@ | |||
| /// Mixin - With Icon | |||
| /// Precede Text with SVG icon | |||
| @mixin with-icon { | |||
There was a problem hiding this comment.
Pretty sure we don't need this anymore. This was harder with SVG in the CSS background and doesn't apply to the new setup using the SVG element.
There was a problem hiding this comment.
Cool. I'll delete this file. I didn't know, so I didn't want to remove code that I wasn't familiar with.
There was a problem hiding this comment.
@evanmwillhite Do all of the other icon files stay there? e.g. Am I just deleting this scss file?
| } | ||
| } | ||
|
|
||
| /// Use the breakout mixin for elements that should be edge-to-edge |
There was a problem hiding this comment.
No worries - it was a minor nitpick to begin with. More prescriptive than my taste for Emulsify "core," but you're right about it not simplifying the breakout mixin. I was thinking we could get rid of some of the breakout mixin args, but you're using them all anyway.
I don't think a post/video is necessary for such a small piece of code (although showing off how it was used on a client project might be cool). It might not hurt to add some CSS comments or a link to someone else's post in the code (not necessary but maybe helpful for someone who hadn't come across that technique).
I might have got a bit overboard. I just wanted to add the
wrapperandbreakoutmixins, but I couldn't help but clean up the mixins, colors, and apply a real basic facelift to the Pattern Lab interface.All of this is negotiable, but I thought it looked good.
I'd particularly like @amazingrando to take a quick look at the new design*