Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

222: removed inheritance of ALL item modifiers #312

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

evanmwillhite
Copy link
Contributor

#222: Children menu items incorrectly inheriting ALL item modifiers

Description:
Implements the great patch proposed in #222 (comment) to ensure original menu item modifiers get passed down but not ones that are specific to a specific level (e.g., main-menu__item--with-sub)

To review:

  • Before checking out this branch, view the source of the Main Menu and verify that every dropdown child incorrectly has the class main-menu__item--with-sub
  • Checkout this branch and verify that only the dropdown items with a dropdown below them have that class.

Copy link
Contributor

@ModulesUnraveled ModulesUnraveled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this on projects. :shipit:

@evanmwillhite evanmwillhite merged commit 1932274 into develop Dec 11, 2018
@evanmwillhite evanmwillhite deleted the 222--menu-item-inheritance branch December 11, 2018 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants