-
Notifications
You must be signed in to change notification settings - Fork 70
115: ES6 support, ESLint, Babel 7 Upgrade and Babel Polyfill #322
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple thoughts in here, I'm not the best front end javascript person so it's worth getting other eye balls on this :)
One additional note, I noticed you have both a yarn.lock
and a package-lock.json
file in this repo. If these get out of sync at any point, it could create some weird side effects and conflicts. You might want to consider standardizing on either yarn or npm.
This would be amazing, I'm really missing ESLint nagging me about how to improve/fix my javascript. |
@evanmwillhite Passes code review. After someone functional tests, we're good. |
@@ -0,0 +1,3 @@ | |||
> 0.5% | |||
not dead | |||
ie 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using browserlist, I think the emulsify-gulp gulp-css.js and gulp-config.js files needs to be updated, so you won't pass browser arguments through the cssConfig.autoPrefixerBrowsers variable anymore?
Maybe it could be augmented so the variable will accept the autoprefixer options? like {grid: autoplace}?
https://github.com/fourkitchens/emulsify-gulp/pull/108/files
115: Add ESlint for JS
This PR changed from addressing merely ESLint to moving to ES6 syntax support for all default code.
Companion PR in Emulsify Gulp fourkitchens/emulsify-gulp#108. Must be merged/deployed at the same time.
Changes/additions:
To Test:
npm link
to test the Emulsify Gulp PR (I couldn't get it to work), make sure you've done that and checked out theeslint-dep
branch there. If it doesn't work for you either, replace^4.0.0
withfourkitchens/emulsify-gulp#eslint-dep
in this line of package.json (please don't commit the change) and runyarn
.yarn start
and ensure there are no errors and that the JS components (accordion, main menu (mobile) and tabs) work correctly in all browsers including IE11