Merge pull request #2028 from fractal-analytics-platform/2023-wrong-n…

…ewline-escaping-in-part-of-task-collection-log

Fix wrong newline escaping Task collection log

CHANGELOG.md

@@ -27,7 +27,8 @@
     * Add `FractalSSH.remote_exists` method (\#2008).
 * Testing:
     * Drop `fetch-depth` from `checkout` in GitHub actions (\#2039).
-
+* Internal:
+    * Fix escaping of newlines within f-strings (\#2028).
 
 # 2.8.1
 

fractal_server/utils.py

@@ -108,8 +108,10 @@ def execute_command_sync(
     stdout = res.stdout
     stderr = res.stderr
     logger.debug(f"{returncode=}")
-    logger.debug(f"{stdout=}")
-    logger.debug(f"{stderr=}")
+    logger.debug("STDOUT:")
+    logger.debug(stdout)
+    logger.debug("STDERR:")
+    logger.debug(stderr)
     if res.returncode != 0:
         logger.debug(f"ERROR in subprocess call to '{command}'")
         raise RuntimeError(

tests/v2/03_api/test_api_task_collection.py

@@ -69,6 +69,10 @@ async def test_task_collection_from_wheel(
         assert res.status_code == 200
         task_group_activity = res.json()
         debug(task_group_activity)
+
+        assert task_group_activity["log"].count("\n") > 0
+        assert task_group_activity["log"].count("\\n") == 0
+
         assert task_group_activity["status"] == "OK"
         assert task_group_activity["timestamp_ended"] is not None
         # Check that log were written, even with CRITICAL logging level