Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix anythingButRange range parameters type #76

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

carafelix
Copy link
Contributor

@carafelix carafelix commented Jul 5, 2024

changed anythingButRange parameters to string following the .range parameters

  • The function checks for characters, not the charcodes, so the appropriate type is string, same as in the .range method. Check the issue bellow for examples.
  • [ x ] Is there a related issue?
  • [ x ] Does the code style reasonably match the existing code?
  • [ x ] Are the changes tested (using the existing format, as far as is possible?)
  • [ x ] Is the index.d.ts file updated, using appropriate types and using the same description as the readme?

@francisrstokes francisrstokes merged commit 781663d into francisrstokes:master Jul 5, 2024
@francisrstokes
Copy link
Owner

Thanks for taking time out of your busy schedule investigating Sumerian mind-viruses to fix this 😄

Closes #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants