Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabbed view for Employee form #31940

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Aug 23, 2022

Before

employee-before

After

employee-tabbed

no-docs

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #31940 (9c1baee) into develop (57257a1) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #31940      +/-   ##
===========================================
+ Coverage    63.32%   63.34%   +0.02%     
===========================================
  Files          813      813              
  Lines        57621    57621              
===========================================
+ Hits         36489    36502      +13     
+ Misses       21132    21119      -13     
Impacted Files Coverage Δ
erpnext/accounts/party.py 77.43% <0.00%> (-4.46%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 70.65% <0.00%> (-3.27%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.15% <0.00%> (-3.19%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 65.67% <0.00%> (-2.71%) ⬇️
erpnext/assets/doctype/asset/asset.py 81.92% <0.00%> (-0.83%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 79.02% <0.00%> (-0.70%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 76.87% <0.00%> (-0.69%) ⬇️
erpnext/stock/doctype/batch/batch.py 83.33% <0.00%> (-0.62%) ⬇️
... and 19 more

@ruchamahabal ruchamahabal marked this pull request as draft August 23, 2022 12:01
@ruchamahabal ruchamahabal added the backport version-14-hotfix backport to version 14 label Sep 5, 2022
@ruchamahabal ruchamahabal marked this pull request as ready for review September 6, 2022 04:48
@ruchamahabal ruchamahabal merged commit 5ab5811 into frappe:develop Sep 6, 2022
@ruchamahabal ruchamahabal deleted the emp-tabbed-view branch September 6, 2022 04:48
ruchamahabal added a commit to ruchamahabal/erpnext that referenced this pull request Sep 6, 2022
frappe-pr-bot pushed a commit that referenced this pull request Sep 6, 2022
# [14.1.0](v14.0.3...v14.1.0) (2022-09-06)

### Bug Fixes

* **Appointment:** create lead notes as child table ([00a73c7](00a73c7))
* fetch from parent not working for custom field ([76ae4d8](76ae4d8))
* force delete old report docs (backport [#32026](#32026)) ([#32027](#32027)) ([0e9a1fb](0e9a1fb))
* include payment against PO in AR/AP report ([4bbd0ec](4bbd0ec))
* incorrect import parameter for cancel PDA ([f55881a](f55881a))
* key error on consolidated financial report ([4409f11](4409f11))
* KSA VAT report multi currency amount issue ([b96526e](b96526e))
* Loan Interest accruals for 0 rated loans ([1b9082e](1b9082e))
* Naming series in Journal Entry Template ([5520c6b](5520c6b))
* not able to make variant item ([f871dd4](f871dd4))
* **pos:** error while consolidating pos invoices ([319ee41](319ee41))
* remove spaces and order import ([055556b](055556b))
* upgrade process to version-14 when currency opportunity wass not set ([4cb685a](4cb685a))
* validate available qty for consumption in SCR ([26536da](26536da))

### Features

* better Item Price list view ([#31954](#31954)) ([784fb47](784fb47))
* tabbed view for Employee form ([#31940](#31940)) ([#32095](#32095)) ([3c688df](3c688df))
* two new filters for gross profit ([60fa421](60fa421))
@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant