fix(Salary Assignment): skip warning for missing opening entries in t…

…he absence of tax components (backport #2472) (#2477) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Aysha <[email protected]>
frappe · Dec 4, 2024 · 531d16b · 531d16b
1 parent 2bfd0b0
commit 531d16b
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/hrms/payroll/doctype/salary_structure_assignment/salary_structure_assignment.py b/hrms/payroll/doctype/salary_structure_assignment/salary_structure_assignment.py
@@ -169,6 +169,9 @@ def warn_about_missing_opening_entries(self):
 
 	@frappe.whitelist()
 	def are_opening_entries_required(self) -> bool:
+		if not get_tax_component(self.salary_structure):
+			return False
+
 		if self.has_emp_joined_after_payroll_period_start() and not self.has_existing_salary_slips():
 			return True
 		else: