Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Earned Leave UX Enhancement #1156

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented Dec 11, 2023

Issue

Closes: #1104

Changes

Monthly leave allocation schedule

Shows the date and the number of leaves to be allocated each month in the Leave Allocation form dashboard. This table is only rendered for Earned Leaves with 'Monthly' frequency.

image

Notification of auto-allocation failure

In case of failure of auto-allocation of Earned Leaves, an email is sent to the users with the 'HR Manager' role, notifying them of said failure.

Manual allocation of leaves

"Allocate Leaves Manually" button to circumvent missed Leave Allocations due to failed background jobs. Number of leaves is defaulted to the monthly number of leaves to be allocated.

image

Documentation

https://frappehr.com/docs/v14/en/configuring-earned-leave

hrms/hr/utils.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Merging #1156 (d272681) into develop (a741b51) will decrease coverage by 0.47%.
Report is 123 commits behind head on develop.
The diff coverage is 26.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1156      +/-   ##
===========================================
- Coverage    72.75%   72.28%   -0.47%     
===========================================
  Files          199      200       +1     
  Lines        10769    10922     +153     
===========================================
+ Hits          7835     7895      +60     
- Misses        2934     3027      +93     
Files Coverage Δ
hrms/hr/utils.py 71.31% <26.82%> (-5.69%) ⬇️

... and 10 files with indirect coverage changes

@krantheman krantheman force-pushed the earned-leave-enhancement branch from 8a83922 to cf000ad Compare December 12, 2023 07:59
@krantheman krantheman force-pushed the earned-leave-enhancement branch from cf000ad to 378f4be Compare December 12, 2023 08:02
@krantheman krantheman force-pushed the earned-leave-enhancement branch from 9f4eb11 to 1b75334 Compare December 13, 2023 07:00
@krantheman krantheman marked this pull request as ready for review December 13, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Earned Leave UX
3 participants