-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: leave type wise leave block dates #142
Conversation
Unrelated test failing. |
1 similar comment
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #142 +/- ##
===========================================
- Coverage 70.84% 70.78% -0.07%
===========================================
Files 178 178
Lines 8943 8960 +17
===========================================
+ Hits 6336 6342 +6
- Misses 2607 2618 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test cases in the "leave block list" test controller for getting applicable block dates with leave type (single and all lists)
@ruchamahabal I have added test cases, also modified the test data; added |
@ruchamahabal please check |
Any reason to do this? |
None of the test actually check for it, so while adding new test records, I added that key as well 😬 |
1 similar comment
@rtdany10 thank you for the contribution. A note for the future contributions: Avoid commit messages like |
Noted, will keep the commit message descriptive from now on. |
This PR gives user the ability to block leave days by leave type.
Peek.2022-10-29.19-01.mp4